| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path |
| Date: | 2020-11-24 20:43:47 |
| Message-ID: | CAApHDvp9uxVqOPk6KadZV0Od2GNzem447MYuxbZOLUNFmdAy5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 25 Nov 2020 at 04:48, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2020-11-24 01:52, Dagfinn Ilmari Mannsåker wrote:
> > The Clang documentation¹ suggest an even neater solution, which would
> > eliminate the repetitive empty pg_attribute_foo #defines in the trailing
> > #else/#endif block in commit 1fa22a43a56e1fe44c7bb3a3d5ef31be5bcac41d:
> >
> > #ifndef __has_attribute
> > #define __has_attribute(x) 0
> > #endif
>
> Yes, this was also mentioned and agreed earlier in the thread, but then
> we apparently forgot to update the patch.
I wanted to let the buildfarm settle a bit before changing this again.
I plan on making the change today.
(I know walleye is still not happy)
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-11-24 20:44:16 | Re: bug in pageinspect's "tuple data" feature |
| Previous Message | Anastasia Lubennikova | 2020-11-24 20:18:44 | Ready For Committer patches (CF 2020-11) |