Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py

From: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Date: 2021-10-31 18:02:46
Message-ID: c404df0f-0f6b-f513-fa52-0edc2e569be6@cmatte.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Hello,

>
> And finally, settings.py already contains:
> try:
>     from .local_settings import *
> except ImportError:
>     pass
>
>
> Just a couple of lines above where you are adding it back again. Is that also for some reason not working?

Right, I missed that. It's just that in pgweb and pgarchives, the file is called settings_local.py, whereas pglister calls it local_settings.py. This is just a question of naming consistency, then. Do you think it's worth patching?

> Second, I'm not sure why we want to exclude local_settings.py from pycodestyle in general?

It's ignored in pgweb, I just assumed there was a good reason for that and did the same thing for consistency.

Cheers,
--
Célestin Matte

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Daniel Gustafsson 2021-11-02 11:15:36 Warning on snapshot downloads
Previous Message Magnus Hagander 2021-10-31 15:27:29 Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py