Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Date: 2021-10-31 15:27:29
Message-ID: CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Wed, Oct 27, 2021 at 4:02 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
wrote:

> Following the model of pgweb and pgarchives
>

Hi!

local_settings.py is already ignored in web/pglister/.gitignore -- does
that not work for some reason? It works fine from here.

Second, I'm not sure why we want to exclude local_settings.py from
pycodestyle in general?

And finally, settings.py already contains:
try:
from .local_settings import *
except ImportError:
pass

Just a couple of lines above where you are adding it back again. Is that
also for some reason not working?

And it is important that it is included before we do the exim part for
example -- otherwise you cannot control that from within local_settings.py.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Célestin Matte 2021-10-31 18:02:46 Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Previous Message Célestin Matte 2021-10-28 17:43:43 [PATCH 2/2] pgarchives: Add missing example pgauth config in settings.py