Fix logging for invalid recovery timeline

From: David Steele <david(at)pgbackrest(dot)org>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix logging for invalid recovery timeline
Date: 2024-12-20 15:37:36
Message-ID: c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

I noticed while debugging a user issue that the checkpoint logged in

"Latest checkpoint is at %X/%X on timeline %u, but in the history of the
requested timeline, the server forked off from that timeline at %X/%X."

is being pulled from the value stored in the control file rather than
the value read from backup_label (in the case where there is a
backup_label). This only affects logging since the timeline check is
done against the checkpoint/TLI as read from backup_label.

This patch updates the checkpoint and TLI to (what I believe are) the
correct values for logging.

I think this should also be back-patched.

Regards,
-David

Attachment Content-Type Size
timeline-log-v1.patch text/plain 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-12-20 16:02:55 Document How Commit Handles Aborted Transactions
Previous Message Tom Lane 2024-12-20 15:35:01 Re: pure parsers and reentrant scanners