Re: Fix logging for invalid recovery timeline

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: David Steele <david(at)pgbackrest(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix logging for invalid recovery timeline
Date: 2024-12-21 04:28:57
Message-ID: C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 20 Dec 2024, at 20:37, David Steele <david(at)pgbackrest(dot)org> wrote:
>
> "Latest checkpoint is at %X/%X on timeline %u, but in the history of the requested timeline, the server forked off from that timeline at %X/%X."

I think errdetai here is very hard to follow. I seem to understand what is going on after reading errmsg, but errdetai makes me uncertain.

If we call "tliSwitchPoint(CheckPointTLI, expectedTLEs, NULL);"
don't we risk to have again
ereport(ERROR,
(errmsg("requested timeline %u is not in this server's history",
tli)));
?

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2024-12-21 05:22:39 Re: Discussion on a LISTEN-ALL syntax
Previous Message Tom Lane 2024-12-21 04:23:29 Re: Discussion on a LISTEN-ALL syntax