Re: [PATCHES] Extending grant insert on tables to sequences

From: "Jaime Casanova" <systemguards(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>, "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Extending grant insert on tables to sequences
Date: 2008-07-08 16:10:45
Message-ID: c2d9e70e0807080910m7cb65cd0i3ecb449ca8fed17d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 7/8/08, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> Jaime Casanova escribió:
> > On Thu, May 22, 2008 at 1:18 PM, Jaime Casanova <systemguards(at)gmail(dot)com> wrote:
> > > Hi,
> > >
> > > The idea of this patch is to avoid the need to make explicit grants on
> > > sequences owned by tables.
> >
> > I've noted that the patch i attached is an older version that doesn't
> > compile because of a typo...
> > Re-attaching right patch and fix documentation to indicate the new behaviour...
>
> I had a look at this patch and it looks good. The only thing that's not
> clear to me is whether we have agreed we want this to be the default
> behavior?
>

mmm... i don't remember from where i took the equivalences...
i will review if there is any concensus in that...
anyway now i when people should speak about it...

>
> Wouldn't it be clearer to build a list with all the sequences owned by
> the tables in istmt.objects, and then call ExecGrantStmt_oids() a single
> time with the big list?
>

at night i will see the code for this...

--
regards,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Guayaquil - Ecuador
Cel. (593) 87171157

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-07-08 16:11:40 Re: [patch] plproxy v2
Previous Message Joshua D. Drake 2008-07-08 15:58:39 Re: [patch] plproxy v2

Browse pgsql-patches by date

  From Date Subject
Next Message Josh Berkus 2008-07-08 16:35:32 Re: [PATCHES] Solaris ident authentication using unix domain sockets
Previous Message Bernd Helmle 2008-07-08 15:14:15 Add missing descriptions for aggregates, functions and conversions