| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | kuznetsovam(at)altlinux(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | nickel(at)altlinux(dot)org, egori(at)altlinux(dot)org |
| Subject: | Re: Check for tuplestorestate nullness before dereferencing |
| Date: | 2024-10-14 13:41:53 |
| Message-ID: | c28626b6-5bfb-4ba1-bfd8-c821ded51985@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.10.2024 12:25, Alexander Kuznetsov wrote:
> Hello everyone,
>
> I'd like to propose adding a check for the nullness of tuplestorestate
> before dereferencing it
> in src/backend/executor/nodeModifier.c. The patch is attached.
>
> I am proposing this fix based on the assumption that tuplestorestate
> could be NULL
> since there is a check for it when calculating eof_tuplestore at line 85.
> However, since this code hasn't been changed since 2006 and hasn't
> caused any issues,
> it is possible that the check for (tuplestorestate == NULL) is
> redundant when calculating eof_tuplestore.
>
Hi Alexander,
The 'tuplestorestate' variable may be initialized at line 64 if it is
NULL. You should consider initializing this variable earlier.
Regards,
Ilia Evdokimov,
Tantor Labs LLC.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-10-14 14:30:49 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |
| Previous Message | Peter Eisentraut | 2024-10-14 13:08:32 | Re: Add support to TLS 1.3 cipher suites and curves lists |