| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, gdo(at)leader(dot)it, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Date: | 2023-06-10 19:07:05 |
| Message-ID: | c23d6ec1-f882-af48-82d9-54e9f3e15809@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 6/10/23 14:42, Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> 5/ The attached fixes the issue for me on pg10 and passes check-world.
>> Comments?
>
> The call in PGLC_localeconv seems *very* oddly placed. Why not
> do that before it does any other locale calls? Otherwise you don't
> really have reason to believe you're saving the appropriate
> values to restore later.
As far as I can tell it really only affects localeconv(), so I tried to
place it close to those. But I am fine with moving it up.
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2023-06-10 19:28:47 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Previous Message | Tom Lane | 2023-06-10 18:42:54 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2023-06-10 19:28:47 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Previous Message | Tom Lane | 2023-06-10 18:42:54 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |