Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tristan Partin <tristan(at)neon(dot)tech>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, gdo(at)leader(dot)it, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
Date: 2023-06-10 18:42:54
Message-ID: 665279.1686422574@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Joe Conway <mail(at)joeconway(dot)com> writes:
> 5/ The attached fixes the issue for me on pg10 and passes check-world.
> Comments?

The call in PGLC_localeconv seems *very* oddly placed. Why not
do that before it does any other locale calls? Otherwise you don't
really have reason to believe you're saving the appropriate
values to restore later.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Joe Conway 2023-06-10 19:07:05 Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
Previous Message Joe Conway 2023-06-10 16:12:36 Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2023-06-10 19:07:05 Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
Previous Message Hannu Krosing 2023-06-10 18:01:47 Re: Let's make PostgreSQL multi-threaded