Re: logicalrep_message_type throws an error

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: logicalrep_message_type throws an error
Date: 2023-07-15 13:45:40
Message-ID: bf9a0803-a65b-494a-8b4a-40ab0cc75b16@app.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 15, 2023, at 4:27 AM, Amit Kapila wrote:
> Do you have something like attached in mind?

WFM. I would change the comment that says

This function is called to provide context in the error ...

to

This message provides context in the error ...

because this comment is not at the beginning of the function but *before* the
message.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2023-07-15 14:20:28 Re: Use of additional index columns in rows filtering
Previous Message Amit Kapila 2023-07-15 11:18:14 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication