| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: logicalrep_message_type throws an error |
| Date: | 2023-07-17 02:17:40 |
| Message-ID: | CAA4eK1JatUtoE-hNx9cP3WfD+kWPDASfM9xjZoJfM78Y42sMZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 15, 2023 at 7:16 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Sat, Jul 15, 2023, at 4:27 AM, Amit Kapila wrote:
>
> Do you have something like attached in mind?
>
>
> WFM. I would change the comment that says
>
> This function is called to provide context in the error ...
>
> to
>
> This message provides context in the error ...
>
> because this comment is not at the beginning of the function but *before* the
> message.
>
Sounds reasonable to me. I'll make this modification before pushing
unless there are more comments/suggestions.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2023-07-17 02:37:28 | Re: ALTER TABLE SET ACCESS METHOD on partitioned tables |
| Previous Message | Zhang Mingli | 2023-07-17 01:55:07 | Re: Improve heapgetpage() performance, overhead from serializable |