| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | 李杰(慎追) <adger(dot)lj(at)alibaba-inc(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 曾文旌(义从) <wenjing(dot)zwj(at)alibaba-inc(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: DROP INDEX CONCURRENTLY on partitioned index |
| Date: | 2021-03-05 14:27:05 |
| Message-ID: | be48b899-2230-bfe8-00cf-ce552b7c6767@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
On 10/27/20 8:44 PM, Justin Pryzby wrote:
>
>> 3. I have a patch which changes index_drop() to "expand" a partitioned index into
>> its list of children. Each of these becomes a List:
>> | indexId, heapId, userIndexRelation, userHeapRelation, heaplocktag, heaprelid, indexrelid
>> The same process is followed as for a single index, but handling all partitions
>> at once in two transactions total. Arguably, this is bad since that function
>> currently takes a single Oid but would now ends up operating on a list of indexes.
>
> This is what's implemented in the attached. It's very possible I've missed
> opportunities for better simplification/integration.
It appears there are still some issues to be resolved with this patch,
but the next step seems to be for you to have a look at Justin's most
recent patch.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2021-03-05 14:32:29 | Re: PoC/WIP: Extended statistics on expressions |
| Previous Message | David Steele | 2021-03-05 14:11:47 | Re: pgbench - add pseudo-random permutation function |