Re: exclude tmp_check and tmp_install from pgindent

On 10/08/2018 05:49 AM, Peter Eisentraut wrote:
> pgindent spends a long time digging through tmp_check and tmp_install
> directories and ends up re-indenting installed header files. How about
> excluding those directories, like below or directly in the script?
>
> diff --git a/src/tools/pgindent/exclude_file_patterns
> b/src/tools/pgindent/exclude_file_patterns
> index 65c42c131d..c8efc9a913 100644
> --- a/src/tools/pgindent/exclude_file_patterns
> +++ b/src/tools/pgindent/exclude_file_patterns
> @@ -6,3 +6,5 @@
> /snowball/libstemmer/
> /pl/plperl/ppport\.h$
> /jit/llvmjit\.h$
> +/tmp_check/
> +/tmp_install/
>

Seems reasonable - I tend to do vpath builds so this hasn't been a
problem for me ;-)

I wonder if a more general solution might be a good idea. Say like
ignoring everything pointed to by

    git status --porcelain --ignored

with a status of '??' (untracked) or '!!' (ignored).

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services