| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: exclude tmp_check and tmp_install from pgindent |
| Date: | 2018-10-08 13:37:49 |
| Message-ID: | 26234.1539005869@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 10/08/2018 05:49 AM, Peter Eisentraut wrote:
>> pgindent spends a long time digging through tmp_check and tmp_install
>> directories and ends up re-indenting installed header files. How about
>> excluding those directories, like below or directly in the script?
> I wonder if a more general solution might be a good idea. Say like
> ignoring everything pointed to by
> git status --porcelain --ignored
Peter's idea sounds better to me. We don't have that many derived .c
or .h files, so I doubt the "git status" calls would pay for themselves.
(Personally, I don't run pgindent in non-cleaned trees ...)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-10-08 13:39:23 | Re: pgsql: Fix event triggers for partitioned tables |
| Previous Message | Michael Paquier | 2018-10-08 13:13:33 | Re: exclude tmp_check and tmp_install from pgindent |