From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: Tips on committing |
Date: | 2018-06-29 12:39:34 |
Message-ID: | bd78cdd0-516d-952d-cc06-61e3a47888d0@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 06/29/2018 02:19 PM, Michael Paquier wrote:
> On Fri, Jun 29, 2018 at 02:04:07PM +0200, Peter Eisentraut wrote:
>> On 6/28/18 17:14, Alvaro Herrera wrote:
>>>> 2 Reported-by:
>>>> 5 Author:
>>>> 6 Reviewed-by:
>>>> 7 Tested-by:
>>> Should these include email addresses?
>>
>> One reason I include emails is that sometimes the names are spelled
>> in inconsistent ways or don't include ASCII characters at all. An
>> email address is always clear.
>
> I don't know if emails are actually a good idea to include. Those
> tend to change when folks change company, and a lot of people here
> use company-based email addresses to discuss and work on patches.
Why would that be a problem? It's not a stable identifier, but it also
does not change very often. Also, those who submit patches from company
addresses do it because the patch comes from that company, and I think
it's a good idea to keep that information.
While it might not be the primary goal, I assume people will try to
process those fields by various scripts (generating stats, charts, ...).
E-mails seem to be easier to correlate than just names.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-06-29 13:23:22 | pgsql: Replace search.cpan.org with metacpan.org |
Previous Message | Michael Paquier | 2018-06-29 12:23:13 | Re: Tips on committing |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2018-06-29 12:48:33 | Re: Monitoring time of fsyncing WALs |
Previous Message | Robert Haas | 2018-06-29 12:30:13 | Re: Remove mention in docs that foreign keys on partitioned tables are not supported |