| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Tips on committing |
| Date: | 2018-06-29 12:19:26 |
| Message-ID: | 20180629121926.GB8939@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jun 29, 2018 at 02:04:07PM +0200, Peter Eisentraut wrote:
> On 6/28/18 17:14, Alvaro Herrera wrote:
>>> 2 Reported-by:
>>> 5 Author:
>>> 6 Reviewed-by:
>>> 7 Tested-by:
>> Should these include email addresses?
>
> One reason I include emails is that sometimes the names are spelled in
> inconsistent ways or don't include ASCII characters at all. An email
> address is always clear.
I don't know if emails are actually a good idea to include. Those tend
to change when folks change company, and a lot of people here use
company-based email addresses to discuss and work on patches.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-29 12:23:13 | Re: Tips on committing |
| Previous Message | Peter Eisentraut | 2018-06-29 12:04:07 | Re: Tips on committing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuzmenkov | 2018-06-29 12:22:04 | Re: Generating partitioning tuple conversion maps faster |
| Previous Message | Surafel Temesgen | 2018-06-29 12:09:44 | Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data |