Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Amit Langote <amitlangote09(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions
Date: 2024-07-05 13:16:12
Message-ID: bce99b9c-e3ff-8e90-f8b2-ad4859513e54@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Op 7/5/24 om 14:35 schreef Amit Langote:
> Hi Jian,
>
> Thanks for the reviews.
>
> [v3-0001-SQL-JSON-Various-improvements-to-SQL-JSON-query-f.patch]
i.e., from the patch for doc/src/sgml/func.sgml

Small changes:

4x:
'a SQL' should be
'an SQL'
('a SQL' does never occur in the docs; it's always 'an SQL'; apperently
the 'sequel' pronunciation is out)

'some other type to which can be successfully coerced'
'some other type to which it can be successfully coerced'

'specifies the behavior behavior'
'specifies the behavior'

In the following sentence:

"By default, the result is returned as a value of type <type>jsonb</type>,
though the <literal>RETURNING</literal> clause can be used to return
the original <type>jsonb</type> value as some other type to which it
can be successfully coerced."

it seems to me that this phrase is better removed:
"the original <type>jsonb</type> value as"

thanks,

Erik

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Frank Streitzig 2024-07-05 13:33:52 XML test error on Arch Linux
Previous Message Heikki Linnakangas 2024-07-05 13:08:07 Re: Improving the latch handling between logical replication launcher and worker processes.