From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Erik Rijkers <er(at)xs4all(dot)nl> |
Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions |
Date: | 2024-07-08 11:48:32 |
Message-ID: | CA+HiwqEPSh0zG9LFOOWvFBMRocAcDaUTUmTupq97xeQ+CESG4Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 5, 2024 at 10:16 PM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> Op 7/5/24 om 14:35 schreef Amit Langote:
> > Hi Jian,
> >
> > Thanks for the reviews.
> >
> > [v3-0001-SQL-JSON-Various-improvements-to-SQL-JSON-query-f.patch]
> i.e., from the patch for doc/src/sgml/func.sgml
>
>
> Small changes:
>
> 4x:
> 'a SQL' should be
> 'an SQL'
> ('a SQL' does never occur in the docs; it's always 'an SQL'; apperently
> the 'sequel' pronunciation is out)
>
> 'some other type to which can be successfully coerced'
> 'some other type to which it can be successfully coerced'
>
>
> 'specifies the behavior behavior'
> 'specifies the behavior'
>
>
> In the following sentence:
>
> "By default, the result is returned as a value of type <type>jsonb</type>,
> though the <literal>RETURNING</literal> clause can be used to return
> the original <type>jsonb</type> value as some other type to which it
> can be successfully coerced."
>
> it seems to me that this phrase is better removed:
> "the original <type>jsonb</type> value as"
Thanks, I've addressed all these in the next patch I'll send.
--
Thanks, Amit Langote
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-07-08 11:55:01 | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |
Previous Message | ikedarintarof | 2024-07-08 11:44:56 | Re: doc: modify the comment in function libpqrcv_check_conninfo() |