Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Subject: Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence
Date: 2024-05-15 06:15:37
Message-ID: bc57073e-27a3-4a4a-9d93-ef734d473a74@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 15.05.24 02:00, Michael Paquier wrote:
> On Tue, May 14, 2024 at 10:39:36AM +0200, Peter Eisentraut wrote:
>> I saw the same thing. The problem is that there is incomplete dependency
>> information in the makefiles (not meson) between src/common/ and what is
>> using it. So whenever anything changes in src/common/, you pretty much have
>> to do a forced rebuild of everything.
>
> Is that a recent regression? I have some blurry memories from
> working on these areas that changing src/common/ reflected on the
> compiled pieces effectively at some point.

One instance of this problem that I can reproduce at least back to PG12 is

1. touch src/common/exec.c
2. make -C src/bin/pg_dump

This will rebuild libpgcommon, but it will not relink pg_dump.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-15 08:14:14 pgsql: Make all Perl warnings fatal, catch-up
Previous Message Michael Paquier 2024-05-15 05:32:16 pgsql: Add missing newline at the end of index_including.sql

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2024-05-15 07:26:17 Re: Introduce new multi insert Table AM and improve performance of various SQL commands with it for Heap AM
Previous Message Michael Paquier 2024-05-15 06:13:23 Re: SQL:2011 application time