Re: intagg.sgml: example wrongly named and does not compile

From: Christophe Courtois <christophe(dot)courtois(at)dalibo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-docs(at)postgresql(dot)org
Subject: Re: intagg.sgml: example wrongly named and does not compile
Date: 2017-04-21 16:07:13
Message-ID: ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Le 21/04/2017 à 17:45, Tom Lane a écrit :
> Christophe Courtois <christophe(dot)courtois(at)dalibo(dot)com> writes:
>> I've found out that the example in intagg.sgml is wrongly named: the
>> one-to-many table is a many-to-many.
> Well, it'd depend on how it was used. The example clearly intends that
> it be one-to-many, and I'm not sure it still makes sense without that
> restriction. Maybe better to add a unique constraint on
> one_to_many(left)?

Perhaps the whole example can be simplified to get rid of the "left"
table, but I didn't intend to rewrite it.

>> And my colleague Thibaut Madeleine has seen that the "CREATE TABLE
>> right" and "CREATE TABLE left" examples cannot compile due to the
>> reserved words.
> Ouch. Shows you how old this module is :-(

Indeed.

>> I propose the attached patch to fix that.
> Um, the attached file seems empty from here.

Ooops, sorry. It is attached.

--
Christophe Courtois
Consultant Dalibo
http://dalibo.com/ - http://dalibo.org/

Attachment Content-Type Size
intagg.sgml.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-21 19:33:50 Re: There is one "a" too much
Previous Message Tom Lane 2017-04-21 15:45:16 Re: intagg.sgml: example wrongly named and does not compile