| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Michael Banck <mbanck(at)gmx(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Holger Jakobs <holger(at)jakobs(dot)com>, Jeff Davis <jdavis(at)postgresql(dot)org> |
| Subject: | Re: Improve error message for ICU libraries if pkg-config is absent |
| Date: | 2024-08-15 01:05:19 |
| Message-ID: | b903792ab7ca37af4be6d959ce1ea5b548f19391.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2024-08-09 at 11:44 +0200, Michael Banck wrote:
> So maybe the better change is to just remove the explicit error
> message
> again and depend on PKG_CHECK_MODULES erroring out helpfully? The
> downside would be that the hint about specifying --without-icu to get
> around this would disappear, but I think somebody building from
> source
> can figure that out more easily than the subtle issue that pkg-config
> is
> not installed.
That looks good to me. Does anyone have a different opinion? If not,
I'll go ahead and commit (but not backport) this change.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-08-15 02:09:29 | Re: Typo in unicode_assigned() document PG17 |
| Previous Message | Jeff Davis | 2024-08-15 00:56:46 | Re: Skip adding row-marks for non target tables when result relation is foreign table. |