| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-20 13:49:13 |
| Message-ID: | b7fcae21-7227-806c-5441-9470db9da608@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 10/19/2017 11:25 AM, Michael Paquier wrote:
> On Thu, Oct 19, 2017 at 10:13 PM, Andrew Dunstan
> <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>>
>> On 10/18/2017 10:07 PM, Michael Paquier wrote:
>>> Please see the attached patch which considers all the discussion done,
>>> which shapes the code in the way I see most suited for HEAD and
>>> back-branches.
>>
>> Patch doesn't apply against HEAD.
>>
>> Also, don't we need more tests?
> Oops. Sorry about that. v3 is incorrect, I messed up the origin commit
> for the diffs generated. Here you go as attached.
Looks good. Do you want to produce patches for the back branches also?
this applies to REL_10 but not earlier. If not I'll work on it this weekend.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-21 03:40:39 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | bharti.bhandari | 2017-10-20 13:18:10 | BUG #14864: PostgresSQL script is skipping to process random records |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2017-10-20 14:07:25 | Re: 64-bit queryId? |
| Previous Message | Robert Haas | 2017-10-20 13:44:18 | Re: 64-bit queryId? |