| From: | Jim Nasby <jim(dot)nasby(at)openscg(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: objsubid vs subobjid |
| Date: | 2017-03-05 21:10:45 |
| Message-ID: | b78a075e-784e-da4b-bd94-01ea410fcf52@openscg.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/1/17 9:24 AM, Peter Eisentraut wrote:
> On 3/1/17 09:51, Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>>> On 2/22/17 19:35, Jim Nasby wrote:
>>>> pg_get_object_address() currently returns a field called subobjid, while
>>>> pg_depend calls that objsubid. I'm guessing that wasn't on purpose
>>>> (especially because internally the function uses objsubid), and it'd be
>>>> nice to fix it.
>>>
>>> I'm in favor of changing it, but it could theoretically break someone's
>>> code.
>>
>> Yes, it was an oversight. +1 for changing.
>
> OK done.
BTW, did you backpatch as well? The function was added in 9.5.
Presumably we wouldn't normally do that, but if we think this is unused
enough maybe it's worth it.
--
Jim Nasby, Chief Data Architect, OpenSCG
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2017-03-05 21:12:13 | Re: Change in "policy" on dump ordering? |
| Previous Message | Jim Nasby | 2017-03-05 21:09:44 | Re: Faster methods for getting SPI results (460% improvement) |