Re: pgsql: Refer to replication origin roident as "ID" in user facing messa

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refer to replication origin roident as "ID" in user facing messa
Date: 2022-08-18 09:49:15
Message-ID: b70cd33b-82fb-c2d6-442c-5f719079ff91@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 18.08.22 04:10, John Naylor wrote:
> While at it, most format strings already use %u, so for consintency
> change the remaining stragglers using %d.

This is incorrect. Replication origin IDs are of type uint16, which
gets promoted to int in a variable arguments list, so %d is the correct
placeholder.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-08-18 09:50:19 pgsql: Simplify and clarify an error message
Previous Message Thomas Munro 2022-08-18 04:34:02 pgsql: Remove configure probe for sys/sockio.h.