Re: pgsql: Refer to replication origin roident as "ID" in user facing messa

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refer to replication origin roident as "ID" in user facing messa
Date: 2022-08-19 01:06:51
Message-ID: CAFBsxsEMiQA-HbhcPT=_nqLhAb6YX0mhxr+WQFcuqeMznkew_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Aug 18, 2022 at 4:49 PM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 18.08.22 04:10, John Naylor wrote:
> > While at it, most format strings already use %u, so for consintency
> > change the remaining stragglers using %d.
>
> This is incorrect. Replication origin IDs are of type uint16, which
> gets promoted to int in a variable arguments list, so %d is the correct
> placeholder.

I would think that for uint16, either %d or %u would have the same
result. Is there some other consideration I'm not aware of?

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-08-19 09:22:22 pgsql: Move a definition inside a header file
Previous Message Michael Paquier 2022-08-19 01:02:41 pgsql: doc: Improve some markups and some wording around archiving modu