| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tristan Partin <tristan(at)neon(dot)tech>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: Use FD_CLOEXEC on ListenSockets (was Re: Refactoring backend fork+exec code) |
| Date: | 2023-10-05 12:08:37 |
| Message-ID: | b666fe49-e700-4fc7-0d34-41e51849a9b3@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/08/2023 09:58, Heikki Linnakangas wrote:
> On 29/08/2023 09:21, Heikki Linnakangas wrote:
>> Thinking about this some more, the ListenSockets array is a bit silly
>> anyway. We fill the array starting from index 0, always append to the
>> end, and never remove entries from it. It would seem more
>> straightforward to keep track of the used size of the array. Currently
>> we always loop through the unused parts too, and e.g.
>> ConfigurePostmasterWaitSet() needs to walk the array to count how many
>> elements are in use.
>
> Like this.
This seems pretty uncontroversial, and I heard no objections, so I went
ahead and committed that.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2023-10-05 12:10:37 | Re: Good News Everyone! + feature proposal |
| Previous Message | Dave Cramer | 2023-10-05 12:08:36 | Change of behaviour for creating same type name in multiple schemas |