Re: patch: fix to use ``pg_get_functiondef()``

From: Andrej Antonov <antonov(at)imp-m(dot)ru>
To: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: patch: fix to use ``pg_get_functiondef()``
Date: 2015-12-14 07:51:15
Message-ID: b6449f1093463ef4820c5e1ddd5a21a9@imp-m.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

thank you, Dmitriy. I agree -- this-fix should works better.

I applyed this-fix to my local-git-branches ("REL-1_20_0-impulsm" and
"fix-to-use-pg_get_functiondef"). works good.

Dmitriy Olshevskiy писал 2015-12-13 18:04:
> Hi, Andrej!
> Here is small fix of your patch - can you check it please?
> I think there must be wxwidgets function IsEmpty() instead of double
> negation,
> because type of the variable is wxstring. Also I added the Trim()
> function before
> check if function definition is empty or not.
>
> On 08.12.2015 11:50, Andrej Antonov wrote:
>
>> patch: fix to use ``pg_get_functiondef()`` [see attachment file]
>>
>> it is copy of pull-request
>> https://github.com/postgres/pgadmin3/pull/12 [1]
>>
>> thank you!
>
> --
> Dmitriy Olshevskiy
>
>
> Links:
> ------
> [1] https://github.com/postgres/pgadmin3/pull/12

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2015-12-15 10:32:21 pgAdmin III commit: Update for RC1
Previous Message Dmitriy Olshevskiy 2015-12-13 15:04:52 Re: patch: fix to use ``pg_get_functiondef()``