| From: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> |
|---|---|
| To: | Andrej Antonov <antonov(at)imp-m(dot)ru>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: patch: fix to use ``pg_get_functiondef()`` |
| Date: | 2015-12-13 15:04:52 |
| Message-ID: | 566D8914.2070507@bk.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi, Andrej!
Here is small fix of your patch - can you check it please?
I think there must be wxwidgets function IsEmpty() instead of double
negation,
because type of the variable is wxstring. Also I added the Trim()
function before
check if function definition is empty or not.
On 08.12.2015 11:50, Andrej Antonov wrote:
> patch: fix to use ``pg_get_functiondef()`` [see attachment file]
>
> it is copy of pull-request https://github.com/postgres/pgadmin3/pull/12
>
> thank you!
>
>
>
--
Dmitriy Olshevskiy
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-using-pg_get_functiondef-fixed.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrej Antonov | 2015-12-14 07:51:15 | Re: patch: fix to use ``pg_get_functiondef()`` |
| Previous Message | P O'Toole | 2015-12-09 19:37:58 | pgAdmin's internal find-replace/search-replace dialog using regex groups in the replace-box? |