Re: Array initialisation notation in syscache.c

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Array initialisation notation in syscache.c
Date: 2023-09-21 08:19:41
Message-ID: b5d094e9-560c-bddb-015a-d39a57d64139@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 31.03.23 04:16, Thomas Munro wrote:
> From the light relief department, here is some more variadic macrology:
>
> - tp = SearchSysCache1(TSPARSEROID, ObjectIdGetDatum(prsId));
> + tp = SearchSysCache(TSPARSEROID, ObjectIdGetDatum(prsId));

I'm worried that if we are removing the variants with the explicit
numbers, it will make it difficult for extensions to maintain
compatibility with previous PG major versions. They would probably have
to copy much of your syscache.h changes into their own code. Seems messy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-09-21 08:20:28 Re: [PoC] pg_upgrade: allow to upgrade publisher node
Previous Message Ryoga Yoshida 2023-09-21 08:06:59 Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z