Re: [PATCH] Make pkg-config files cross-compile friendly

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Sebastian Kemper <sebastian_ml(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Make pkg-config files cross-compile friendly
Date: 2021-09-03 14:58:33
Message-ID: b47c8273-5e19-f9f5-cc7f-fd63edad8304@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.03.20 22:38, Sebastian Kemper wrote:
> This commit addresses this by doing the following two things:
>
> 1. Instead of hard coding the paths in "Cflags" and "Libs"
> "${includedir}" and "${libdir}" are used. Note: these variables can
> be overriden on the pkg-config command line
> ("--define-variable=libdir=/some/path").
>
> 2. Add the variables "prefix" and "exec_prefix". If "includedir"
> and/or "libdir" are using these then construct them accordingly.
> This is done because buildroots (for instance OpenWrt) tend to
> rename the real pkg-config and call it indirectly from a script
> that sets "prefix", "exec_prefix" and "bindir", like so:

Committed. I simplified your code a little bit, and I also made it so
that exec_prefix is set to ${prefix} by default. That way it matches
what most other .pc files I have found do.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-09-03 15:03:45 Re: Trap errors from streaming child in pg_basebackup to exit early
Previous Message Tom Lane 2021-09-03 14:39:33 Re: Add guc to enable send SIGSTOP to peers when backend exits abnormally