Re: Add guc to enable send SIGSTOP to peers when backend exits abnormally

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: 蔡梦娟(玊于) <mengjuan(dot)cmj(at)alibaba-inc(dot)com>
Cc: "pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add guc to enable send SIGSTOP to peers when backend exits abnormally
Date: 2021-09-03 14:39:33
Message-ID: 2498875.1630679973@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"=?UTF-8?B?6JSh5qKm5aifKOeOiuS6jik=?=" <mengjuan(dot)cmj(at)alibaba-inc(dot)com> writes:
> I want to share a patch with you, in which I add a guc parameter 'enable_send_stop' to enable set the value of SendStop in postmaster.c more conveniently. SendStop enable postmaster to send SIGSTOP rather than SIGQUIT to its children when some backend dumps core, and this variable is originally set with -T parameter when start postgres, which is inconvenient to control in some scenarios.

TBH, I'd sooner rip out SendStop, and simplify the related postmaster
logic. I've never used it in twenty-some years of Postgres hacking,
and I doubt anyone else has used it much either. It's not worth the
overhead of a GUC. (The argument that you need it in situations
where you can't control the postmaster's command line seems pretty
thin, too. I'm much more worried about somebody turning it on by
accident and then complaining that the cluster freezes upon crash.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-09-03 14:58:33 Re: [PATCH] Make pkg-config files cross-compile friendly
Previous Message Robert Haas 2021-09-03 14:37:59 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints