| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-08-16 12:18:31 |
| Message-ID: | b38c7d2b-5d31-466f-bc19-3f61954f180b@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/07/2024 06:41, Noah Misch wrote:
> On Tue, Jul 02, 2024 at 02:42:50PM +0300, Heikki Linnakangas wrote:
>> On 02/07/2024 02:24, Noah Misch wrote:
>>> On Tue, Jul 02, 2024 at 12:53:05AM +0300, Heikki Linnakangas wrote:
>>>> Fortunately, fsync() on a file that's already flushed to disk is pretty
>>>> cheap.
>>>
>>> Yep. I'm more concerned about future readers wondering why the function is
>>> using LSNs to decide what to do about data that doesn't appear in WAL. A
>>> comment could be another way to fix that, though.
>>
>> Agreed, this is all very subtle, and deserves a good comment. What do you
>> think of the attached?
>
> Looks good. Thanks. pgindent doesn't preserve all your indentation, but it
> doesn't make things objectionable, either.
Committed, thanks!
(Sorry for the delay, I had forgotten about this already and found it
only now sedimented at the bottom of my inbox)
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-08-16 12:31:27 | Re: Make query cancellation keys longer |
| Previous Message | Amul Sul | 2024-08-16 11:47:47 | Ineffective Assert-check in CopyMultiInsertInfoNextFreeSlot() |