| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-07-03 03:41:31 |
| Message-ID: | 20240703034131.e1.nmisch@google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 02, 2024 at 02:42:50PM +0300, Heikki Linnakangas wrote:
> On 02/07/2024 02:24, Noah Misch wrote:
> > On Tue, Jul 02, 2024 at 12:53:05AM +0300, Heikki Linnakangas wrote:
> log_newpage_range() loads the pages to the buffer
> cache and dirties them. That kinds of sucks actually, I wish it didn't need
> to dirty the buffers.
Agreed.
> > > Fortunately, fsync() on a file that's already flushed to disk is pretty
> > > cheap.
> >
> > Yep. I'm more concerned about future readers wondering why the function is
> > using LSNs to decide what to do about data that doesn't appear in WAL. A
> > comment could be another way to fix that, though.
>
> Agreed, this is all very subtle, and deserves a good comment. What do you
> think of the attached?
Looks good. Thanks. pgindent doesn't preserve all your indentation, but it
doesn't make things objectionable, either.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-07-03 03:44:53 | Re: Cleaning up perl code |
| Previous Message | Alexander Korotkov | 2024-07-03 03:39:09 | Re: Removing unneeded self joins |