| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_rewind copies |
| Date: | 2021-01-22 13:26:12 |
| Message-ID: | b2ebc855-61e3-818b-d6b8-cddf3e3d8816@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16/12/2020 00:08, Cary Huang wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: not tested
>
> Hello
>
> The patch seems to do as described and the regression and tap tests are passing
> + /*
> + * A local source is not expected to change while we're rewinding, so check
> + * that we size of the file matches our earlier expectation.
> + */
> Is this a tyoo?
Yep, thanks! Attached is a new patch version, with that fixed and
rebased. No other changes.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_rewind-Fetch-small-files-according-to-new-size.patch | text/x-patch | 10.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 'Alvaro Herrera' | 2021-01-22 13:38:20 | Re: libpq debug log |
| Previous Message | Masahiko Sawada | 2021-01-22 13:23:46 | Re: LogwrtResult contended spinlock |