From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_rewind copies |
Date: | 2021-03-25 13:32:05 |
Message-ID: | 171fd136-d523-57fd-6f03-26eea9427136@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 1/22/21 8:26 AM, Heikki Linnakangas wrote:
> On 16/12/2020 00:08, Cary Huang wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world: tested, passed
>> Implements feature: tested, passed
>> Spec compliant: tested, passed
>> Documentation: not tested
>>
>> Hello
>>
>> The patch seems to do as described and the regression and tap tests
>> are passing
>> + /*
>> + * A local source is not expected to change while we're
>> rewinding, so check
>> + * that we size of the file matches our earlier expectation.
>> + */
>> Is this a tyoo?
>
> Yep, thanks! Attached is a new patch version, with that fixed and
> rebased. No other changes.
Cary, does this patch look ready to commit? If so, please change the
state in the CF entry to "Ready for Committer".
Regards,
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2021-03-25 13:33:34 | Re: PoC/WIP: Extended statistics on expressions |
Previous Message | Andrew Dunstan | 2021-03-25 13:25:11 | Re: Refactor SSL test framework to support multiple TLS libraries |