Re: Convert node test compile-time settings into run-time parameters

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Convert node test compile-time settings into run-time parameters
Date: 2024-07-25 07:51:35
Message-ID: b1173b58-5b73-4bf4-a87e-6792f7b4cff2@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.05.24 16:39, Tom Lane wrote:
>>> Maybe not three settings, but a single setting, with multiple values, like
>>> debug_io_direct?
>> Yeah, good idea. Let's get some more feedback on this before I code up
>> a complicated list parser.
> Kinda doubt it's worth the trouble, either to code the GUC support or
> to use it. I don't object to having the booleans in a debug build,
> I was just concerned about whether they should exist in production.

Right. My inclination is to go ahead with the patch as proposed at this
time. There might be other ideas for tweaks in this area, but they
could be applied as new patches on top of this. The main goal here was
to do $subject, and without overhead for production builds, and this
accomplishes that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-07-25 08:16:58 Re: pg_upgrade and logical replication
Previous Message Pradeep Kumar 2024-07-25 07:39:50 rare crash - FailedAssertion snapbuild.c Line: 580