Re: ISN extension - wrong volatility level for isn_weak() function

From: Viktor Holmberg <v(at)viktorh(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
Date: 2025-03-15 21:17:16
Message-ID: b08ed3b6-eba7-47f5-b354-5e4ec1fb8632@Spark
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Oh, sorry! Don’t know what I was doing there - not used to this patch based workflow. Here comes the real patch.
This now uses the GUC - that was a lot easier than I thought.
One thing I couldn’t figure out: Should I add some sort of change log somewhere, describing what changed in version 1.3 of the ISN extension? If so, where?

/Viktor Holmberg
On 15 Mar 2025 at 16:22 +0000, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, wrote:
> Viktor Holmberg <v(at)viktorh(dot)net> writes:
> > On 14 Mar 2025 at 16:18 +0000, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, wrote:
> > > No, we'd need to create an update script that uses ALTER FUNCTION.
> > > Extension scripts are basically frozen once shipped.
>
> > Ah, thanks for the clarification. I’ve attached a patch that fixes the volatility. I thought it best to at least get some feedback on that before I try to dust off my C knowledge and try to fix the GUC stuff.
>
> Uh .. looks like you attached a patch for something else altogether.
>
> If you want a sample extension-updating patch to look at, you
> could see 44ba2920644903d7dfceda810e5facdbcbab58a8, or lots of
> other examples.
>
> regards, tom lane

Attachment Content-Type Size
0001-isn-extension-Make-weak-mode-a-GUC-setting.patch application/octet-stream 12.9 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2025-03-15 21:35:57 Re: ISN extension - wrong volatility level for isn_weak() function
Previous Message Tom Lane 2025-03-15 17:22:57 Re: BUG #18845: DEREF_OF_NULL.RET guc_malloc possibly returns NULL