| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fe-utils - share query cancellation code |
| Date: | 2019-12-03 12:11:27 |
| Message-ID: | alpine.DEB.2.21.1912031157110.653@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bonjour Michaël,
>> Committed the patch after splitting things into two commits and after
>> testing things from Linux and from a Windows console: the actual
>> refactoring and the pgbench changes.
>
> I have found that we have a useless declaration of CancelRequested in
> common.h, which is already part of cancel.h.
Ok.
> On top of that I think that we need to rework a bit the header
> inclusions of bin/scripts/, as per the attached.
Looks fine to me: patch applies, compiles, runs.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-12-03 12:35:00 | Re: Using XLogFileNameP in critical section |
| Previous Message | Alexander Korotkov | 2019-12-03 12:06:09 | Allow relocatable extension to use @extschema@? |