| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fe-utils - share query cancellation code |
| Date: | 2019-12-03 10:16:25 |
| Message-ID: | 20191203101625.GF1634@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 02, 2019 at 11:54:02AM +0900, Michael Paquier wrote:
> Committed the patch after splitting things into two commits and after
> testing things from Linux and from a Windows console: the actual
> refactoring and the pgbench changes.
I have found that we have a useless declaration of CancelRequested in
common.h, which is already part of cancel.h. On top of that I think
that we need to rework a bit the header inclusions of bin/scripts/, as
per the attached. A small set of issues, still these are issues.
Sorry for having missed these.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| cancel-fixes.patch | text/x-diff | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-12-03 10:55:10 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Konstantin Knizhnik | 2019-12-03 09:58:24 | Re: Yet another vectorized engine |