Re: [patch]socket_timeout in interfaces/libpq

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "nagaura(dot)ryohei(at)fujitsu(dot)com" <nagaura(dot)ryohei(at)fujitsu(dot)com>, "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org>, "k(dot)jamison(at)jp(dot)fujitsu(dot)com" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, 'Kyotaro HORIGUCHI' <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "'robertmhaas(at)gmail(dot)com'" <robertmhaas(at)gmail(dot)com>, "MikalaiKeida(at)ibagroup(dot)eu" <MikalaiKeida(at)ibagroup(dot)eu>, "AYahorau(at)ibagroup(dot)eu" <AYahorau(at)ibagroup(dot)eu>, "tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Subject: Re: [patch]socket_timeout in interfaces/libpq
Date: 2019-11-27 09:29:33
Message-ID: alpine.DEB.2.21.1911271022450.17954@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Michaël,

>> Not this round.
>
> You have registered yourself as a reviewer of this patch since the end
> of June. Could you please avoid that? Sometimes people skips patches
> when they see someone already registered to review it.

Yep. ISTM that I did a few reviews on early versions of the patch, which
was really a set of 3 patches.

> The patch applies cleanly so I am movingit to next CF.
>
> (FWIW, I still have the same impression as upthread, looking again at
> the patch, but let's see if there are other opinions.)

AFAICR, I was partly dissuated to pursue reviews by your comment that
somehow the feature had no clear consensus, so I thought that the patch
was implicitely rejected.

Although I work for free, I try to avoid working for nothing:-)

It is still unclear from your above comment whether the patch would ever
get committed, so this does not motivate spending time on it.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-11-27 09:42:17 Re: pglz performance
Previous Message Michael Paquier 2019-11-27 09:18:31 Re: Batch insert in CTAS/MatView code