Re: Removing useless \. at the end of copy in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Removing useless \. at the end of copy in pgbench
Date: 2018-07-28 13:44:21
Message-ID: alpine.DEB.2.21.1807280941001.5142@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Tatsuo-san,

> If we want to support pre 7.4 backend (which only supports the version
> 2 protocol), we could test the current protocol version and decide
> whether we should send out "\." or not, but I doubt it's necessary.
>
> Comments?

Code tested, ok.

I agree that compatibility with protocol v2 (pg 7.4) is not an issue.

As Tom, I would not have bothered, though, however once it is there why
not?

Should the doc state that pgbench compatibility is ok from pg 8.0?

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-07-28 14:03:49 pgbench - add pseudo-random permutation function
Previous Message Amit Kapila 2018-07-28 13:40:24 Re: Problem while setting the fpw with SIGHUP