Re: Problem while setting the fpw with SIGHUP

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Problem while setting the fpw with SIGHUP
Date: 2018-07-28 13:40:24
Message-ID: CAA4eK1L_XucGEtGHwY4HQMSvuRBwyQQqeZRK58XVikFzCuKvHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 24, 2018 at 7:10 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> At Tue, 24 Apr 2018 08:52:17 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20180423235217(dot)GB1570(at)paquier(dot)xyz>
>> On Mon, Apr 23, 2018 at 12:21:04PM -0400, Robert Haas wrote:
>> > Fine, but that doesn't answer the question of whether we actually need
>> > to or should change the behavior in the first place.
>>
>> Per the last arguments that would be "No, we don't want to change it as
>> it would surprise some users":
>> https://www.postgresql.org/message-id/20180420010402.GF2024@paquier.xyz
>
> The answer is that the change of behavior is not required to fix
> the bug. So I'm fine with applying only (0001 and) 0002 here.
>

I have just responded to your first patch (0001). Can you once again
summarize what the 0002 exactly accomplishes? I think one of the
goals is to fix the original problem reported in this thread and other
is you have found the concurrency issue. Is it possible to have
separate patches for those or you think they are interrelated and
needs to be fixed together?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-07-28 13:44:21 Re: Removing useless \. at the end of copy in pgbench
Previous Message Amit Kapila 2018-07-28 13:35:22 Re: Problem while setting the fpw with SIGHUP