| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: pgbench tap tests & minor fixes |
| Date: | 2017-06-15 19:10:12 |
| Message-ID: | alpine.DEB.2.20.1706152107020.4597@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> As for me, I would do expr_scanner_chomp_substring(PsqlScanState, int, int&);
> that changes end_offset as desired...
Why not.
> And use it instead of end_offset = expr_scanner_offset(sstate) - 1;
I removed these?
> The second issue: you are removing all trailing \n and \r. I think you should
> remove only one \n at the end of the string, and one \r before \n if there was
> one.
So chomp one eol.
Is the attached version better to your test?
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-tap-8.patch | text/x-diff | 30.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-06-15 19:16:36 | Re: WIP Patch: Pgbench Serialization and deadlock errors |
| Previous Message | Robert Haas | 2017-06-15 19:09:32 | Re: WIP: Data at rest encryption |