Re: pgbench tap tests & minor fixes

В письме от 15 июня 2017 21:10:12 Вы написали:
> > As for me, I would do expr_scanner_chomp_substring(PsqlScanState, int,
> > int&); that changes end_offset as desired...
>
> Why not.
>
> > And use it instead of end_offset = expr_scanner_offset(sstate) - 1;
>
> I removed these?
>
> > The second issue: you are removing all trailing \n and \r. I think you
> > should remove only one \n at the end of the string, and one \r before \n
> > if there was one.
>
> So chomp one eol.
>
> Is the attached version better to your test?

I've expected from expr_scanner_chomp_substring to decrement end_offset, so it
would work more like perl chomp function, but the way you've done is also
good.

The sad think is that in v7 and v8 TAP tests fails. (in v6 it still works, I
have local branches for all your patches versions). I did not check it bdefore
in v7, just read the code. It was my mistake

--
Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)