Re: pgsql: Fix pgbench's failure to honor the documented long-form option "

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix pgbench's failure to honor the documented long-form option "
Date: 2017-03-07 17:54:12
Message-ID: alpine.DEB.2.20.1703071850330.12504@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


> Not only did it not accept --builtin as a synonym for -b, but what it did
> accept as a synonym was --tpc-b (huh?), which it got even further wrong
> by marking as no_argument, so that if you did try that you got a core
> dump. I suppose this is leftover from some early design for the new
> switches added by commit 8bea3d221, but it's still pretty sloppy work.

Argh, shame on me. I think at some point --tpc-b was an alias for the
default script which then got replaced by builtin + name, but the
implementation did not follow the upgrade:-( Sorry for the result.

--
Fabien.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-07 18:51:53 pgsql: Properly initialize variable.
Previous Message Tom Lane 2017-03-07 17:40:56 pgsql: Invent start_proc parameters for PL/Tcl.