| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fix pgbench's failure to honor the documented long-form option " |
| Date: | 2017-03-10 03:09:32 |
| Message-ID: | 20170310030932.b762pstg6cosw7xc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fabien COELHO wrote:
>
> > Not only did it not accept --builtin as a synonym for -b, but what it did
> > accept as a synonym was --tpc-b (huh?), which it got even further wrong
> > by marking as no_argument, so that if you did try that you got a core
> > dump. I suppose this is leftover from some early design for the new
> > switches added by commit 8bea3d221, but it's still pretty sloppy work.
>
> Argh, shame on me. I think at some point --tpc-b was an alias for the
> default script which then got replaced by builtin + name, but the
> implementation did not follow the upgrade:-( Sorry for the result.
Ouch, this is terrible. I was so focused on the actual feature that I
forgot to verify that the UI was sane. I know I only tested using -b ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-10 03:45:41 | pgsql: Fix hard-coded relkind constants in assorted src/bin files. |
| Previous Message | Michael Paquier | 2017-03-10 02:18:24 | Re: [COMMITTERS] pgsql: Fix hard-coded relkind constants in pg_dump.c. |