| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: New pgbench functions are misnamed |
| Date: | 2016-05-05 07:40:24 |
| Message-ID: | alpine.DEB.2.10.1605050933270.30701@sto |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I noticed that commit 7e137f846 added functions named max() and min()
> to pgbench's expression syntax. Unfortunately, these functions have
> zilch to do with what max() and min() do in SQL. They're actually more
> like the greatest() and least() server-side functions.
Yep.
> While I can't imagine that we'd ever want to implement true aggregates
> in pgbench expressions, it still seems like this is a recipe for
> confusion. Shouldn't we rename these to greatest() and least()?
My 0,02€: I like the simplicity of min/max names and I think that anyone
would manage to deal with this level of confusion in a pgbench script, so
I would not bother.
But if it is to be changed, best do it now!
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ants Aasma | 2016-05-05 08:39:12 | Re: what to revert |
| Previous Message | Fabien COELHO | 2016-05-05 07:32:48 | Re: [BUGS] Breakage with VACUUM ANALYSE + partitions |