New pgbench functions are misnamed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: New pgbench functions are misnamed
Date: 2016-05-04 21:41:12
Message-ID: 728.1462398072@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that commit 7e137f846 added functions named max() and min()
to pgbench's expression syntax. Unfortunately, these functions have
zilch to do with what max() and min() do in SQL. They're actually more
like the greatest() and least() server-side functions.

While I can't imagine that we'd ever want to implement true aggregates
in pgbench expressions, it still seems like this is a recipe for
confusion. Shouldn't we rename these to greatest() and least()?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-05-04 21:43:55 Re: atomic pin/unpin causing errors
Previous Message Stephen Frost 2016-05-04 21:31:17 Re: pg_dump broken for non-super user