| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: checkpointer continuous flushing - V16 |
| Date: | 2016-02-08 18:52:30 |
| Message-ID: | alpine.DEB.2.10.1602081941140.22398@sto |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Andres,
> Any comments before I spend more time polishing this?
I'm running tests on various settings, I'll send a report when it is done.
Up to now the performance seems as good as with the previous version.
> I'm currently updating docs and comments to actually describe the
> current state...
I did notice the mismatched documentation.
I think I would appreciate comments to understand why/how the ringbuffer
is used, and more comments in general, so it is fine if you improve this
part.
Minor details:
"typedefs.list" should be updated to WritebackContext.
"WritebackContext" is a typedef, "struct" is not needed.
I'll look at the code more deeply probably over next weekend.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-02-08 18:59:08 | Re: proposal: PL/Pythonu - function ereport |
| Previous Message | Robert Haas | 2016-02-08 18:45:37 | Re: a raft of parallelism-related bug fixes |