| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-02-15 16:32:43 |
| Message-ID: | af6605fc-8c53-29c3-a096-d7258b3c0c23@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/5/21 2:55 AM, Ian Lawrence Barwick wrote:
> ...
>
> There's a minor typo in the doc's version of the
> ExecForeignBatchInsert() declaration;
> is:
>
> TupleTableSlot **
> ExecForeignBatchInsert(EState *estate,
> ResultRelInfo *rinfo,
> TupleTableSlot **slots,
> TupleTableSlot *planSlots,
> int *numSlots);
>
> should be:
>
> TupleTableSlot **
> ExecForeignBatchInsert(EState *estate,
> ResultRelInfo *rinfo,
> TupleTableSlot **slots,
> TupleTableSlot **planSlots,
> int *numSlots);
>
> (Trivial patch attached).
>
>
> Forgot to mention the relevant doc link:
>
>
> https://www.postgresql.org/docs/devel/fdw-callbacks.html#FDW-CALLBACKS-UPDATE
> <https://www.postgresql.org/docs/devel/fdw-callbacks.html#FDW-CALLBACKS-UPDATE>
>
Thanks, I'll get this fixed.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-02-15 16:36:00 | Re: POC: postgres_fdw insert batching |
| Previous Message | Tomas Vondra | 2021-02-15 16:07:11 | Re: Improvements and additions to COPY progress reporting |